Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start consolidating events #2292

Merged
merged 9 commits into from
Nov 23, 2023
Merged

start consolidating events #2292

merged 9 commits into from
Nov 23, 2023

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Nov 21, 2023

Summary

Mostly consolidate how events are passed - right now we have a mix of using event-emitters for bubbling up events, and using an event-bus for broadcasting across the Vue-app. This is a legacy architecture when some components were co-located and some where not.

Here we consolidate as much as we can, favouring using the vue-emit rather than the event-bus.
They are kind of the same thing with respect to the designs we have at this stage, but the idea is to pick a single method to make the logic and implementation easier to follow, less error-prone, and to indicate a more de-facto way of handling things rather than having mixed modalities.

TODO: Once this has been achieved we can then further refactor and significantly simplify the vue-templates, and also make things more systematic to add new operators.

Testing

Things should work as before except for Julia-stratify, which is slated to be decommissioned.

@mwdchang mwdchang marked this pull request as ready for review November 22, 2023 18:50
@mwdchang mwdchang requested a review from shawnyama November 22, 2023 18:51
@mwdchang mwdchang merged commit 3cb931c into main Nov 23, 2023
5 checks passed
@mwdchang mwdchang deleted the clean-workflow-redundancies branch November 23, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants