Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamic component routing for operation drilldown #2300

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Nov 23, 2023

Summary

Using <component> to instantiate the drilldown-components dynamically. This will:

  • Keep the size of the template section nearly constant
  • Allows for a more plug-and-play style: we can import components at runtime via await import(path_to_component) and add them into the registry
  • Better enforcement of behaviours across components

Next up are the operation-nodes, they will need to go through some major refactoring, as some of them have the the core-logic embedded in the nodes and need to be shifted to the drilldowns.

Also:

  • I also cleaned out the Julia stratify from the workflow.
  • Cleaned out droppedAssetId hook to set the state, we can directly set the state on node-creation

Testing

No functional changes, workflow should work as before.

@mwdchang mwdchang marked this pull request as ready for review November 23, 2023 03:39
@mwdchang mwdchang requested review from shawnyama, Tom-Szendrey, blanchco and YohannParis and removed request for YohannParis November 23, 2023 03:40
@blanchco
Copy link
Contributor

Looks good, I will need to think if this will clash with our ideas on how we are making the generic drilldown template but it might not be an issue. This looks a lot cleaner

@mwdchang mwdchang merged commit 58a1203 into main Nov 23, 2023
5 checks passed
@mwdchang mwdchang deleted the operation-registry branch November 23, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants