-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drilldown layout, behaviour, and preview #2303
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
blanchco
changed the title
Drilldown layout and behaviour
Drilldown layout, behaviour, and preview
Nov 24, 2023
2 tasks
blanchco
commented
Nov 24, 2023
blanchco
commented
Nov 24, 2023
YohannParis
reviewed
Nov 24, 2023
packages/client/hmi-client/src/components/drilldown/tera-drilldown.vue
Outdated
Show resolved
Hide resolved
packages/client/hmi-client/src/components/drilldown/tera-ops-preview.vue
Outdated
Show resolved
Hide resolved
packages/client/hmi-client/src/components/drilldown/tera-ops-preview.vue
Outdated
Show resolved
Hide resolved
packages/client/hmi-client/src/components/drilldown/tera-ops-preview.vue
Outdated
Show resolved
Hide resolved
packages/client/hmi-client/src/components/drilldown/tera-ops-preview.vue
Outdated
Show resolved
Hide resolved
packages/client/hmi-client/src/components/drilldown/tera-ops-preview.vue
Outdated
Show resolved
Hide resolved
packages/client/hmi-client/src/components/drilldown/tera-ops-preview.vue
Outdated
Show resolved
Hide resolved
shawnyama
reviewed
Nov 24, 2023
packages/client/hmi-client/src/components/drilldown/tera-ops-preview.vue
Outdated
Show resolved
Hide resolved
YohannParis
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This idea for this ticket is to create a generalized format for the
tera-drilldown
componentDefining Tabs
We can add as many tabs as we want by adding the
tabName
prop to a top level element undertera-drilldown
In this example we have added three tabs to the drilldown called ("Tab 1", "Tab 2", "Tab 3")
Defining Tab columns
Taking this further inside each tab, every top level component will be shown in its own evenly-space columns:
In this example. Tab 1 would be split into 3 evenly spaced columns, Tab 2 into 2 evenly spaced columns, and Tab 3 in one column which takes up the entire drilldown.
Video
Here's an example video:
Screen.Recording.2023-11-24.at.2.26.29.PM.mov
sample code from the video.
Preview
There has also been a generic preview section added which is a common component that is shared with some drilldowns called
tera-drilldown-preview
This models the selected output and the developer has the ability to add their own template within the component.
For example
Resolves #(issue)