Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] workflow update to handle multiple runs #2309

Merged
merged 14 commits into from
Nov 28, 2023

Conversation

YohannParis
Copy link
Member

@YohannParis YohannParis commented Nov 24, 2023

Description

  • Workflow can handle multiple runs within a drilldown.
  • This update extends the WorkflowPort to keep track of multiple runs
  • utility functions to change which run is visible, and how to change the state of the operator.

@YohannParis YohannParis added the task Development task label Nov 24, 2023
@YohannParis YohannParis self-assigned this Nov 24, 2023
@YohannParis YohannParis marked this pull request as ready for review November 24, 2023 21:30
@YohannParis YohannParis assigned mwdchang and unassigned YohannParis Nov 24, 2023
@mwdchang
Copy link
Member

The util function may be better served under "services/workflow.ts", that is where the majority of workflow related functions live. This util.ts file is very much simulate/calibrate specific and should get rolled up into something else in my opinin.

@YohannParis
Copy link
Member Author

The util function may be better served under "services/workflow.ts", that is where the majority of workflow related functions live. This util.ts file is very much simulate/calibrate specific and should get rolled up into something else in my opinin.

@mwdchang the function has been moved per your recommendation, which makes sense.

@YohannParis YohannParis assigned YohannParis and unassigned mwdchang Nov 27, 2023
@mwdchang mwdchang merged commit fd7f753 into main Nov 28, 2023
5 checks passed
@mwdchang mwdchang deleted the yohannparis/workflow-update branch November 28, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Development task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants