Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix drilldown header height #2360

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Fix drilldown header height #2360

merged 2 commits into from
Dec 4, 2023

Conversation

blanchco
Copy link
Contributor

@blanchco blanchco commented Dec 4, 2023 •
edited
Loading

Description

  • Fix the drilldown header height and move the documentation link based on wether there are tabs or not
  • documentation link is optional
Screen.Recording.2023-12-04.at.12.52.40.PM.mov

@blanchco blanchco self-assigned this Dec 4, 2023
@blanchco blanchco linked an issue Dec 4, 2023 that may be closed by this pull request
[TASK]: Drilldown header: optional documentation link and a non fixed height #2354
Closed
@blanchco blanchco marked this pull request as ready for review December 4, 2023 18:00
@blanchco blanchco merged commit d0bcc58 into main Dec 4, 2023
5 checks passed
@blanchco blanchco deleted the fix-drilldown-header-height branch December 4, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

Assignees

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK]: Drilldown header: optional documentation link and a non fixed height
2 participants
@blanchco @YohannParis