Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia calibrate initial UI refactor #2364

Merged
merged 11 commits into from
Dec 7, 2023

Conversation

Jami159
Copy link
Contributor

@Jami159 Jami159 commented Dec 4, 2023

This code strips out the code from tera-calibrate-node-julia.vue and puts it in tera-calibrate-julia.vue.
This isn't the final version of the workflow node or the drilldown.

Open questions/concerns that need to be fixed in the future/separate PR:

  • What should the workflow node show after a calibrate was started from the drilldown and a user exited out of the drilldown?
  • What should happen while a calibrate is running but a user has exited out of the drilldown?
    • to further clarify on this point, because the the drilldown component gets unmounted when it's closed, we stop querying the message queue, so in that time the simulation could finish running but we may not have all the intermediate results? (TODO: still need to verify the exact details of what happens in this scenario)

Resolves #2248

@Jami159 Jami159 marked this pull request as ready for review December 7, 2023 02:06
@Jami159 Jami159 requested a review from Tom-Szendrey December 7, 2023 02:06
@Jami159 Jami159 changed the title julia calibrate refactor WIP julia calibrate refactor part 1 Dec 7, 2023
@Jami159 Jami159 merged commit 97f6e02 into main Dec 7, 2023
5 checks passed
@Jami159 Jami159 deleted the julia_calibrate_drilldown_improvement branch December 7, 2023 21:08
@Jami159 Jami159 changed the title julia calibrate refactor part 1 Julia calibrate initial refactor Dec 7, 2023
@Jami159 Jami159 changed the title Julia calibrate initial refactor Julia calibrate initial UI refactor Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Julia calibration UI refinement - update node/drilldown design
3 participants