Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: code to model accepts code id #2373

Merged
merged 4 commits into from
Dec 5, 2023
Merged

feat: code to model accepts code id #2373

merged 4 commits into from
Dec 5, 2023

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Dec 5, 2023 •
edited
Loading

Description

image

@shawnyama
Copy link
Contributor Author

shawnyama commented Dec 5, 2023 •
edited
Loading

A few naming related questions:

  • Are we sticking with "Model from code" or is it now named "Code to model"?
  • Why are we calling the code "code asset" in some places in the UI and some variables as well? Does calling it "code asset" help us understand that there are multiple code files within a code asset?

@shawnyama shawnyama marked this pull request as ready for review December 5, 2023 18:47
@shawnyama shawnyama linked an issue Dec 5, 2023 that may be closed by this pull request
Create/Edit Code to Model operator #2370
Closed
blanchco
blanchco approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@blanchco blanchco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we are calling it code asset since a code asset can refer to either one or multiple code files.

@shawnyama shawnyama merged commit 03834a1 into main Dec 5, 2023
4 checks passed
@shawnyama shawnyama deleted the code-to-model-input branch December 5, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blanchco blanchco blanchco approved these changes

@YohannParis YohannParis YohannParis approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@Jami159 Jami159 Awaiting requested review from Jami159

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create/Edit Code to Model operator
3 participants
@shawnyama @YohannParis @blanchco