Refactor calibrate Julia run selection #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YohannParis
changed the base branch from
main
to
feat-handle-multiple-outputs
YohannParis
changed the base branch from
feat-handle-multiple-outputs
to
main
…M/Terarium into julia_calibrate_run_selection
…M/Terarium into julia_calibrate_run_selection
…M/Terarium into julia_calibrate_run_selection
blanchco
reviewed
Dec 13, 2023
packages/client/hmi-client/src/workflow/ops/model-from-code/tera-model-from-code.vue
Show resolved
Hide resolved
packages/client/hmi-client/src/components/drilldown/tera-drilldown-preview.vue
Outdated
Show resolved
Hide resolved
blanchco
reviewed
Dec 13, 2023
packages/client/hmi-client/src/workflow/ops/calibrate-julia/tera-calibrate-julia.vue
Outdated
Show resolved
Hide resolved
mwdchang
reviewed
Dec 13, 2023
YohannParis
approved these changes
Dec 13, 2023
blanchco
approved these changes
Dec 13, 2023
YohannParis
reviewed
Dec 14, 2023
packages/client/hmi-client/src/workflow/ops/calibrate-julia/tera-calibrate-julia.vue
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Julia calibrate run selection to use the new approach with
WorkflowOutputs.This is the initial PR, it will be further refactored later to match designs.
Screen.Recording.2023-12-11.at.4.01.06.PM.mov