Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading tooling #2399

Merged
merged 19 commits into from
Dec 12, 2023
Merged

Upgrading tooling #2399

merged 19 commits into from
Dec 12, 2023

Conversation

YohannParis
Copy link
Member

@YohannParis YohannParis commented Dec 11, 2023

Description

  • Updating Yarn to v4.0.2, which removing the workspace plugin, now part of main codebase.
  • Updating Vite to v5.0.7
  • Updating Node LTS to 20.10.0
  • Updated Prettier, and run the formatting on all the existing files
  • Update Dockerfile to remove GitHub linting comments
  • Other tooling

@YohannParis YohannParis marked this pull request as ready for review December 11, 2023 21:12
@mwdchang
Copy link
Member

There are quite many formatting changes here, are those automatic or did you do them manually?

Ideally I think it would be good if we don't massively change coding-styles en mass at the current time as it makes it harder to track history/changes.

@YohannParis
Copy link
Member Author

There are quite many formatting changes here, are those automatic or did you do them manually?

Ideally I think it would be good if we don't massively change coding-styles en mass at the current time as it makes it harder to track history/changes.

Those are done by Prettier upgraded version. I solved all the issues resolving from the upgrading of the tooling. As doing in multiple round would be annoying.

@mwdchang
Copy link
Member

Seems generally okay to me - prettier has caused some headaches in the past because it fights with the linter, so we may want to keep an eye out and be extra careful in the next little while. In the past I have seen it eitehr:

  • makes thing on into infinite loops (prettier changes X to Y, linter changes Y back to X)
  • produce non-optimal code for some reason

@YohannParis YohannParis merged commit 4b21bb1 into main Dec 12, 2023
7 checks passed
@YohannParis YohannParis deleted the yohannparis/documents-to-model-operator branch December 12, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants