Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task visualize code blocks #2422

Merged
merged 6 commits into from
Dec 18, 2023
Merged

task visualize code blocks #2422

merged 6 commits into from
Dec 18, 2023

Conversation

blanchco
Copy link
Contributor

@blanchco blanchco commented Dec 14, 2023 •
edited
Loading

Description

  • Showing all input code blocks
  • Saving only added code blocks on state
  • cannot delete a input code block
  • visualize code snippets from code blocks
Screen.Recording.2023-12-15.at.4.02.40.PM.mov

Note: Running with multiple dynamics will need to be done in another PR, this is more just displaying multiple dynamics both inputted ones and ones that we added

@blanchco blanchco self-assigned this Dec 14, 2023
This was linked to issues Dec 14, 2023
Code block coming from the input CANNOT be removed. The delete button should be hidden. #2406
Closed
Allow users to visualize code snippets. #2423
Closed
@blanchco blanchco marked this pull request as ready for review December 15, 2023 21:22
@blanchco blanchco requested review from Jami159, YohannParis and mwdchang and removed request for YohannParis and mwdchang December 15, 2023 21:23
YohannParis
YohannParis approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not forget to add the number of code blocs in the output ports on the Code Asset.

packages/client/hmi-client/src/workflow/ops/model-from-code/tera-model-from-code.vue Show resolved Hide resolved
@blanchco
Copy link
Contributor Author

Do not forget to add the number of code blocs in the output ports on the Code Asset.

Will do as a part of this task #2431

@blanchco blanchco merged commit 299ef2d into main Dec 18, 2023
5 checks passed
@blanchco blanchco deleted the task-visualize-code-blocks branch December 18, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis approved these changes

@Jami159 Jami159 Awaiting requested review from Jami159

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

Assignees

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@blanchco @YohannParis