Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: draggable template card #2429

Merged
merged 21 commits into from
Jan 3, 2024
Merged

feat: draggable template card #2429

merged 21 commits into from
Jan 3, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Dec 15, 2023

Description

Test here: http://localhost:8080/model-template-test

  • Wrote tera-canvas-item.vue to wrap around tera-model-template-card and tera-operator as they both share similar drag/drop behaviour.
  • resize and interactionStatus (bitmasking) are still exclusively done in tera-operator. I don't think tera-model-template-card need those - we can move them into tera-canvas-item later if needed.
  • Side note: got rid of h7 rule as that's not even a valid tag
Screen.Recording.2023-12-15.at.7.00.17.PM.mov

@shawnyama
Copy link
Contributor Author

shawnyama commented Jan 2, 2024

I don't know why specifically the document node expands as I move it left. It's as if the left css attribute is effecting things (from tera-canvas-item). My main changes around this area are moving the minWidth style into tera-canvas-item and removing the main {width: 15rem} from tera-operator. Note that this happens with a document with a long title though I still can't narrow down where its coming from.

Screen.Recording.2024-01-02.at.1.53.28.PM.mov

@shawnyama shawnyama marked this pull request as ready for review January 2, 2024 18:59
@shawnyama shawnyama linked an issue Jan 2, 2024 that may be closed by this pull request
@mwdchang
Copy link
Member

mwdchang commented Jan 2, 2024

I don't know why specifically the document node expands as I move it left. It's as if the left css attribute is effecting things (from tera-canvas-item). My main changes around this area are moving the minWidth style into tera-canvas-item and removing the main {width: 15rem} from tera-operator. Note that this happens with a document with a long title though I still can't narrow down where its coming from.

Screen.Recording.2024-01-02.at.1.53.28.PM.mov

@shawnyama is this still an issue? I can't reproduce.

@shawnyama shawnyama merged commit 32f21ab into main Jan 3, 2024
5 checks passed
@shawnyama shawnyama deleted the drag-template-card branch January 3, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: drag and drop for model-template cards
3 participants