Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design paper-cuts #2432

Merged
merged 13 commits into from
Dec 18, 2023
Merged

Design paper-cuts #2432

merged 13 commits into from
Dec 18, 2023

Conversation

YohannParis
Copy link
Member

@YohannParis YohannParis commented Dec 18, 2023 •
edited
Loading

Description

  • Work with @jamiewaese-uncharted to fix small paper-cuts
  • Move the search bar from the header to the data-explorer

@YohannParis YohannParis marked this pull request as ready for review December 18, 2023 19:15
@YohannParis YohannParis requested review from blanchco and removed request for mwdchang December 18, 2023 19:15
blanchco
blanchco approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@blanchco blanchco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💃, checked out the branch as well and is working fine

packages/client/hmi-client/src/page/data-explorer/components/tera-filter-bar.vue Show resolved Hide resolved
@YohannParis YohannParis merged commit 7e3c90d into main Dec 18, 2023
5 checks passed
@YohannParis YohannParis deleted the paper-cuts branch December 18, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blanchco blanchco blanchco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YohannParis @blanchco