fix: fluent interface kernel session #2437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR handles two things:
Instead of returning null if kernel-session-manager's sendMessage fails, throw an error. This makes the fluent interface a bit less gnarly to read. Instead of
sendMessage(...)?.register
, now it is justsendMessage(...).register
I noticed we send a lot of extra, unneeded messages (e.g. reset) for model-edit, this cleans them up
Testing
No functional changes, can test with one or more operators that leverages the kernel session manager.
For model-edit:
For code-to-mode: