Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: funman hardening part 2 #2480

Merged
merged 13 commits into from
Jan 8, 2024
Merged

chore: funman hardening part 2 #2480

merged 13 commits into from
Jan 8, 2024

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Jan 5, 2024

Summary

Bring Funman closer to existing operator paradigm and the design specification.

  • Adding in the output dropdown/switcher
  • UI tweak to make selecting "interested variables" more usable using a multi-select
  • Fix state saving and restoration bugs, add requestParameters into saved state spec
  • Harden some of the state typing; remove extraneous checks
  • Consolidate usage between model-configuration and model - we don't really need to fetch model
  • Misc cleanups

There is a bit of a change in terms of how states are handles, rather than proxying state directly, state values are copied into separate refs, and are initialized in the setModelOptions function. This is to facilitate switching between different output-ports, as well it makes it a little easier to write changes back into the actual state-object on the node.

Testing

Should be able to run several funman valudations with different configuration values, these should be available in the output dropdown. When switching between different output previews the state should reflect that of the selected output.

@mwdchang mwdchang marked this pull request as ready for review January 5, 2024 22:01
@mwdchang mwdchang requested a review from YohannParis as a code owner January 5, 2024 22:01
@mwdchang mwdchang requested a review from Tom-Szendrey January 5, 2024 22:01
@mwdchang mwdchang merged commit 67e50f9 into main Jan 8, 2024
5 checks passed
@mwdchang mwdchang deleted the funman-hardening-2 branch January 8, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants