-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: funman hardening part 2 #2480
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Szendrey
reviewed
Jan 8, 2024
packages/client/hmi-client/src/workflow/ops/funman/tera-funman.vue
Outdated
Show resolved
Hide resolved
Tom-Szendrey
reviewed
Jan 8, 2024
Tom-Szendrey
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bring Funman closer to existing operator paradigm and the design specification.
There is a bit of a change in terms of how states are handles, rather than proxying state directly, state values are copied into separate refs, and are initialized in the setModelOptions function. This is to facilitate switching between different output-ports, as well it makes it a little easier to write changes back into the actual state-object on the node.
Testing
Should be able to run several funman valudations with different configuration values, these should be available in the output dropdown. When switching between different output previews the state should reflect that of the selected output.