Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sidepanel scroll persists #2529

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix: sidepanel scroll persists #2529

merged 1 commit into from
Jan 15, 2024

Conversation

blanchco
Copy link
Contributor

Description

  • A fix to allow the scroll position in the asset nav sidebar to persist, we now directly go to the overview page when clicking on a nav item. Removing the key attribute will no longer make the component refresh so it keeps the scroll position

BEFORE:

Screen.Recording.2024-01-15.at.4.14.42.PM.mov

AFTER:

Screen.Recording.2024-01-15.at.4.13.39.PM.mov

Resolves #(issue)

@blanchco blanchco self-assigned this Jan 15, 2024
@blanchco blanchco requested a review from shawnyama January 15, 2024 21:16
shawnyama
shawnyama approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@shawnyama shawnyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool 😎

YohannParis
YohannParis approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool indeed 🎉

@blanchco blanchco linked an issue Jan 15, 2024 that may be closed by this pull request
[BUG]: Project resource's pane keeps resetting scroll marker on asset selection #2446
Closed
@blanchco blanchco merged commit ed3c89e into main Jan 15, 2024
5 checks passed
@blanchco blanchco deleted the fix-sidepanel-scroll-persist branch January 15, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnyama shawnyama shawnyama approved these changes

@YohannParis YohannParis YohannParis approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

Assignees

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Project resource's pane keeps resetting scroll marker on asset selection
3 participants
@blanchco @YohannParis @shawnyama