Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Add type to import Types #2537

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

YohannParis
Copy link
Member

@YohannParis YohannParis commented Jan 16, 2024

Description

  • Some issues with types not being imported properly on the front-end.
  • This is a full project replace of import (\{.*\} from '@\/types\/Types';) to import type $1.
  • Fix the issue or enum within types/Types.ts are imported without the type keyword.

Copy link
Contributor

@shawnyama shawnyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would be worth generating a seperate Enums file for the enums

@YohannParis
Copy link
Member Author

I wonder if it would be worth generating a seperate Enums file for the enums

Those are generated automatically from the Java backend, so I do not think it's worth our time.
I'm sure this is something will get use to quite quickly.

@YohannParis YohannParis merged commit 3d8a298 into main Jan 16, 2024
5 checks passed
@YohannParis YohannParis deleted the yohannparis/add-type-to-Tpes-import branch January 16, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants