Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provisionally working branch duplication interaction #2588

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Jan 25, 2024

Summary

Hook up the branch-duplication feature, effectively this just calls the workflowService.branchWorkflow(...) function.

Also fixed a few bugs as there were a few places where the identifier-reassignment were missed - e.g. node.active field.

Duplicate option:

image

After example, the duplicated branch is slightly shifted down.

image

Testing

Using the "duplicate" option on any operator will duplicate itself, and all downstream operator(s).

Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwdchang mwdchang merged commit 73a10f6 into main Jan 25, 2024
5 checks passed
@mwdchang mwdchang deleted the workflow-duplicate-ui branch January 25, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants