Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: call amr to template and add flat view #2639

Merged
merged 15 commits into from
Feb 2, 2024
Merged

feat: call amr to template and add flat view #2639

merged 15 commits into from
Feb 2, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Jan 31, 2024 •
edited
Loading

Description

Screen.Recording.2024-02-01.at.3.14.17.PM.mov
  • call amr_to_template from beaker
  • flat view and flattened model state are available
  • rearranged sidebar layout

Testing

Put a valid model id into model-template-test.vue and go to http://localhost:8080/model-template-test

@shawnyama shawnyama marked this pull request as ready for review January 31, 2024 21:31
@shawnyama shawnyama linked an issue Jan 31, 2024 that may be closed by this pull request
Implement AMR to MMT with the Model Templates #2635
Closed
@shawnyama shawnyama marked this pull request as draft January 31, 2024 21:52
@shawnyama shawnyama marked this pull request as ready for review February 1, 2024 20:16
@mwdchang mwdchang merged commit cdcbb5d into main Feb 2, 2024
5 checks passed
@mwdchang mwdchang deleted the call-amr-mmt branch February 2, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang approved these changes

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement AMR to MMT with the Model Templates
2 participants
@shawnyama @mwdchang