Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: decapodes data structures #2653

Merged
merged 9 commits into from
Feb 5, 2024
Merged

chore: decapodes data structures #2653

merged 9 commits into from
Feb 5, 2024

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Feb 4, 2024

Summary

Add objects for decapode configuration and decapodes context and decapodes configuration.

Some fields are captured as Object, since the fields captures disjunctive typing. e.g. { value: 123, format: 'x' } or { uri: 'abc' } or 8 ... they can be typed out more carefully if needed, but most of these objects are just pass-throughs.

Testing

CRUD operations of configuration/context through swagger-ui.

@mwdchang mwdchang changed the title Decapodes data structures chore: decapodes data structures Feb 4, 2024
@YohannParis YohannParis linked an issue Feb 5, 2024 that may be closed by this pull request
7 tasks
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but still not sure about not using ModelHeader here.

@mwdchang mwdchang merged commit 8c39a70 into main Feb 5, 2024
8 checks passed
@mwdchang mwdchang deleted the decapodes-data-structures branch February 5, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK]: Support Decapodes AMR
3 participants