-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: decapodes data structures #2653
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwdchang
requested review from
dgauldie,
dvince2 and
YohannParis
as code owners
February 4, 2024 21:45
7 tasks
YohannParis
reviewed
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but still not sure about not using ModelHeader
here.
...ava/software/uncharted/terarium/hmiserver/models/dataservice/multiphysics/ContextHeader.java
Outdated
Show resolved
Hide resolved
.../software/uncharted/terarium/hmiserver/models/dataservice/multiphysics/DecapodesContext.java
Show resolved
Hide resolved
...are/uncharted/terarium/hmiserver/models/dataservice/multiphysics/DecapodesConfiguration.java
Show resolved
Hide resolved
.../software/uncharted/terarium/hmiserver/models/dataservice/multiphysics/DecapodesContext.java
Show resolved
Hide resolved
dvince2
reviewed
Feb 5, 2024
.../uncharted/terarium/hmiserver/models/dataservice/multiphysics/ContextPrimalDualRelation.java
Outdated
Show resolved
Hide resolved
dvince2
reviewed
Feb 5, 2024
...tware/uncharted/terarium/hmiserver/models/dataservice/multiphysics/ConfigurationDataset.java
Show resolved
Hide resolved
dvince2
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add objects for decapode configuration and decapodes context and decapodes configuration.
Some fields are captured as Object, since the fields captures disjunctive typing. e.g.
{ value: 123, format: 'x' }
or{ uri: 'abc' }
or8
... they can be typed out more carefully if needed, but most of these objects are just pass-throughs.Testing
CRUD operations of configuration/context through swagger-ui.