Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ciemss simulate using inferred_parameters #2659

Merged
merged 12 commits into from
Feb 7, 2024
Merged

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Feb 5, 2024

Summary

Depends on: #2669

Part 2 of of updating pyciemss calibrate. Lots of smaller things

  • Add optional input-port for ciemss simulate, allow ciemss simulate to use inferred_parameters
  • Removed ciemss extra operators, Sabina said they are largely not needed
  • Fix client-event subscriptions for ciemss
  • Fix MQ erroring out on having messages in the queue but no consumers attached
  • Add loss graph, changed y-axis to use scientific notation
  • Fix simulate-chart jitters via unnecessary rerenders

Remaining issues

  • Loss values not persisted
  • You need to refresh on the workflow view to get the preview to show up
  • CIEMSS loss values are extremely high, not sure if there is some weird bug somewhere

CIEMSS calibrate drilldown:

image

CIEMSS simulate with inferred_parameters:

image

@mwdchang mwdchang marked this pull request as ready for review February 7, 2024 16:11
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

I would have prefer removing the use of ClientEvent but that should be a different PR.

@mwdchang mwdchang merged commit 476b0f3 into main Feb 7, 2024
8 checks passed
@mwdchang mwdchang deleted the ciemss-calibrate-update-2 branch February 7, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants