Small fixes. Add cache bust to puill latest GoLLM in taskrunner build #2670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbirk
requested review from
YohannParis,
j2whiting,
dgauldie and
dvince2
as code owners
dvince2
approved these changes
Feb 6, 2024
dgauldie
reviewed
Feb 6, 2024
...ages/server/src/test/java/software/uncharted/terarium/hmiserver/service/TaskServiceTest.java
Show resolved
Hide resolved
dgauldie
approved these changes
Feb 6, 2024
j2whiting
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue @blanchco was encountering is because the dockerfile layer that pulls the GoLLM repo was getting cached, so it was running code that was out of date :)
Ideally we want to actually hardcode a GoLLM release, but for now, since we are iterating so quickly its nice to just use the latest by default.