Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add model documents to search #2675

Merged
merged 11 commits into from
Feb 9, 2024
Merged

Add model documents to search #2675

merged 11 commits into from
Feb 9, 2024

Conversation

kbirk
Copy link
Contributor

@kbirk kbirk commented Feb 6, 2024

No description provided.

@kbirk kbirk marked this pull request as ready for review February 7, 2024 22:28
bigglesandginger
bigglesandginger approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@bigglesandginger bigglesandginger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested this, and will later today after I drive to my wife's office, but this lloks fine (if a lot of refactoring)

@kbirk kbirk merged commit b7bd68b into main Feb 9, 2024
3 checks passed
@kbirk kbirk deleted the searchable-model-ingest branch February 9, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigglesandginger bigglesandginger bigglesandginger approved these changes

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbirk @bigglesandginger