Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: model edit polish #2694

Merged
merged 16 commits into from
Feb 14, 2024
Merged

feat: model edit polish #2694

merged 16 commits into from
Feb 14, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Feb 9, 2024 •
edited
Loading

Description

  • Inverted beaker calls
  • Determine number to append to the end of a model template card's variables
  • Auto run works properly
  • Rename template sanity check
  • Added templateCard property to ModelMetadata
  • Removed old template card component (I think it came back from some merge)
Screen.Recording.2024-02-13.at.2.09.56.PM.mov
  • tera-model-diagram zoom/pan doesn't work. It seems like it has to do with it not being seen in the window once it's mounted. If I put tera-model-diagram in the Wizard view it works as it should.

@shawnyama shawnyama linked an issue Feb 13, 2024 that may be closed by this pull request
[TASK]: Model template editing clean up #2688
Closed
@shawnyama shawnyama marked this pull request as ready for review February 13, 2024 15:05
@shawnyama shawnyama marked this pull request as draft February 13, 2024 16:01
@shawnyama shawnyama marked this pull request as ready for review February 13, 2024 19:14
@shawnyama shawnyama merged commit f195f6c into main Feb 14, 2024
8 checks passed
@shawnyama shawnyama deleted the model-edit-polish branch February 14, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang approved these changes

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

@dvince2 dvince2 Awaiting requested review from dvince2 dvince2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK]: Model template editing clean up
2 participants
@shawnyama @mwdchang