-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ciemss ensemble simulate #2701
Merged
Merged
Ciemss ensemble simulate #2701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YohannParis
reviewed
Feb 13, 2024
...lient/hmi-client/src/workflow/ops/simulate-ensemble-ciemss/tera-simulate-ensemble-ciemss.vue
Outdated
Show resolved
Hide resolved
YohannParis
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR brings the ciemss-ensemble-simulate operator up to date with the design sketches, and fix various bugs along the way. Because this dates back to when logic was on the node, or partially split across both node/drilldown - the changes here are quite drastic. It might be better to view this as a rewrite than a UI-update.
Note 1: we don't have ensembled results, there is a bug on ciemss, the result data are just showing individual states from each input model configurations.
Note 2: currently this will error out if the input models have different structure. e.g. you cannot do SEIRD + SIR, but you can do two different SIR configs.
The new mechanics:
TODOs: