Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ciemss ensemble simulate #2701

Merged
merged 13 commits into from
Feb 14, 2024
Merged

Ciemss ensemble simulate #2701

merged 13 commits into from
Feb 14, 2024

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Feb 12, 2024

Summary

This PR brings the ciemss-ensemble-simulate operator up to date with the design sketches, and fix various bugs along the way. Because this dates back to when logic was on the node, or partially split across both node/drilldown - the changes here are quite drastic. It might be better to view this as a rewrite than a UI-update.

Note 1: we don't have ensembled results, there is a bug on ciemss, the result data are just showing individual states from each input model configurations.

Note 2: currently this will error out if the input models have different structure. e.g. you cannot do SEIRD + SIR, but you can do two different SIR configs.

The new mechanics:

  • Drilldown initializes the state and run the simulation
  • Node will poll/pull simulation result of the "active" output

TODOs:

  • Display actual ensemble results
  • Clean up UI, there are a handful of UUIDs that should be replaced with names
  • Clean up polling process and precedence across node/drilldown, currently you need to stay in the drilldown for the simulation to finish running.
image

@mwdchang mwdchang marked this pull request as ready for review February 13, 2024 15:30
@mwdchang mwdchang merged commit 78aa5a6 into main Feb 14, 2024
5 checks passed
@mwdchang mwdchang deleted the ciemss-ensemble-simulate branch February 14, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants