Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add template to flat view #2717

Merged
merged 28 commits into from
Feb 16, 2024
Merged

feat: add template to flat view #2717

merged 28 commits into from
Feb 16, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Feb 14, 2024

Description

  • Model template editing can be done in the flattened view
  • As soon as a decomposed card is linked to the flattened card the same edit is applied on the decomposed side
  • Any decomposed cards that are unlinked to the flattened model are ignored

How it works

  • Key system behaviour (how it always worked): The flattened model updates whenever an edit is done in the decomposed view
  • When I add cards/links on the flattened side it is pure UI
  • Once a decomposed card is connected to the flattened card all changes translate to an equivalent edit on the decomposed side (see reflectFlattenedEditInDecomposedView)
  • These decomposed edits then trigger the key system behaviour ^ which "reflattens" or "merges" what's on the flattened view
Screen.Recording.2024-02-16.at.9.47.53.AM.mov

@shawnyama shawnyama linked an issue Feb 14, 2024 that may be closed by this pull request
@shawnyama shawnyama marked this pull request as ready for review February 16, 2024 14:52
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion, we should improve the naming in subsequent PRs. Between the usages of template, model, card, and combinations of the 3 terms it is a bit difficult to understand what is going on.

@shawnyama shawnyama merged commit 1678daf into main Feb 16, 2024
5 checks passed
@shawnyama shawnyama deleted the add-to-flat-view branch February 16, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK]: add template to flattened model
2 participants