Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator active output behaviour #2736

Merged
merged 13 commits into from
Feb 18, 2024
Merged

operator active output behaviour #2736

merged 13 commits into from
Feb 18, 2024

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Feb 16, 2024

Summary

This modifies the behaviour such that a successful run of an operator will make that operator the active output. Moreover, because we agreed to have a singular exposed output per operator, the emission append-output-port is renamed to append-output to better reflect what is actually happening.

I am going to take a crack at harmonizing the behaviour of the preview-dropdown we have in the operators, just chitchatting with Pascale
- if we run something, the output should be selected automatically, currently this seems to be a mix of auto and manual selection after "run" is clicked
- successive runs will replace the existing output. 
- when selected output changes it will propagate the carried value downstream and mark downstream operators as invalid (to be done later but before eval)

Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwdchang mwdchang marked this pull request as ready for review February 18, 2024 18:37
@mwdchang mwdchang merged commit 4ddde70 into main Feb 18, 2024
5 checks passed
@mwdchang mwdchang deleted the operator-active-behaviour branch February 18, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants