Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

funman changes #2755

Merged
merged 7 commits into from
Feb 21, 2024
Merged

funman changes #2755

merged 7 commits into from
Feb 21, 2024

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Feb 20, 2024

Summary

  • Add a compartmental sanity check (mass conservation + non-negativity), this is turned on by default
  • Lower the default tolerance value, 0.89 was too high and we almost always need to lower it
  • Add calculation for normalization constant = sum(eval(initial state expressions))

Testing

Maybe a bit difficult as funman had not been stable since last sync against their develop-branch. Probably want to use simple models like SIR.

@mwdchang mwdchang marked this pull request as ready for review February 21, 2024 15:50
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwdchang mwdchang merged commit c27c9f1 into main Feb 21, 2024
5 checks passed
@mwdchang mwdchang deleted the funman-changes branch February 21, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants