Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: model-config ES errors #2762

Merged
merged 4 commits into from
Feb 21, 2024
Merged

fix: model-config ES errors #2762

merged 4 commits into from
Feb 21, 2024

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Feb 20, 2024

Summary

This fixes two things

  • ES errors when fetching model-configurations via model id cause by non-existing field and typos
  • Do not refresh and fetch a listing of model-configurations a the model-configuration node when the input port is connected, the interaction paradigm has changed and handled in the drilldown instead

The resulting ES error:

{"error":{"root_cause":[{"type":"query_shard_exception","reason":"No mapping found for [timestamp] in order to sort on","index_uuid":"Sgoz2pkbQb2bqF4HlTEW7A","index":"tds_modelconfiguration_tera_2.0"}],"type":"search_phase_execution_exception","reason":"all shards failed","phase":"query","grouped":true,"failed_shards":[{"shard":0,"index":"tds_modelconfiguration_tera_2.0","node":"vjctqqzaQJSQvb-8Uwnlcg","reason":{"type":"query_shard_exception","reason":"No mapping found for [timestamp] in order to sort on","index_uuid":"Sgoz2pkbQb2bqF4HlTEW7A","index":"tds_modelconfiguration_tera_2.0"}}]},"status":400}

Testing

  • ES errors can be tested through GET /models/:id/model-configurations
  • Attach a model to model-configuration operator will not cause ES to error out

Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfection!

@mwdchang mwdchang merged commit 6dd564f into main Feb 21, 2024
8 checks passed
@mwdchang mwdchang deleted the model-configuration-es-error branch February 21, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants