Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search by asset #2765

Merged
merged 27 commits into from
Feb 21, 2024
Merged

feat: search by asset #2765

merged 27 commits into from
Feb 21, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Feb 20, 2024

Description

  • models use the new search-by-asset-type endpoint
  • models assets have the id attribute so we should see the previews in the explorer and them into the project
  • preparing code to transition in using the new search endpoint and to eventually deprecate ResourceType
  • merged some data explorer cleanups/ui updates that I had in another branch
Screen.Recording.2024-02-21.at.11.56.09.AM.mov

@shawnyama shawnyama marked this pull request as ready for review February 21, 2024 17:04
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shawnyama and others added 7 commits February 21, 2024 14:00
…era-search-results-list.vue

Co-authored-by: Yohann Paris <github@yohannparis.com>
…era-preview-panel.vue

Co-authored-by: Yohann Paris <github@yohannparis.com>
….vue

Co-authored-by: Yohann Paris <github@yohannparis.com>
…r.vue

Co-authored-by: Yohann Paris <github@yohannparis.com>
…r.vue

Co-authored-by: Yohann Paris <github@yohannparis.com>
@shawnyama shawnyama merged commit edbdffd into main Feb 21, 2024
5 checks passed
@shawnyama shawnyama deleted the new-search-api branch February 21, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants