-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jamie standardize all the node operator button labels #2768
Merged
YohannParis
merged 44 commits into
main
from
jamie-standardize-all-the-node-operator-button-labels
Feb 21, 2024
Merged
Jamie standardize all the node operator button labels #2768
YohannParis
merged 44 commits into
main
from
jamie-standardize-all-the-node-operator-button-labels
Feb 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiewaese-uncharted
requested review from
YohannParis and
mwdchang
as code owners
February 21, 2024 03:38
YohannParis
approved these changes
Feb 21, 2024
YohannParis
deleted the
jamie-standardize-all-the-node-operator-button-labels
branch
February 21, 2024 12:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of the operators had different words in their buttons to open the drilldown panels. I talked to Pascale today about this and we came up with the following "rule":
So here it is now: