Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update search for document assets #2772

Merged
merged 36 commits into from
Feb 23, 2024
Merged

feat: update search for document assets #2772

merged 36 commits into from
Feb 23, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Feb 21, 2024 •
edited
Loading

Description

Screen.Recording.2024-02-23.at.2.45.19.PM.mov
  • Document assets are fetched instead of the xdd version and they can be added into a project
  • fileNames aren't included in the getDocumentAsset endpoint so I adjusted the conditionals to check for a text property. So for now TXT docs will appear but not PDFs. I let @kbirk know about this issue. Changed the JsonAlias to filenames in DocumentAsset.java so now I always get fileNames
  • Made the search bar a textarea for more of a chat like experience (matches design) and to remove auto complete suggestions
  • Facet bar is collapsed by default

@shawnyama shawnyama changed the base branch from main to new-search-api February 21, 2024 17:45
Base automatically changed from new-search-api to main February 21, 2024 20:43
@shawnyama shawnyama marked this pull request as ready for review February 23, 2024 14:36
@shawnyama shawnyama linked an issue Feb 23, 2024 that may be closed by this pull request
[TASK] Explorer first pass updates #2625
Closed
6 tasks
@YohannParis YohannParis marked this pull request as draft February 23, 2024 16:03
@shawnyama shawnyama marked this pull request as ready for review February 23, 2024 19:43
@shawnyama shawnyama merged commit b453e13 into main Feb 23, 2024
5 checks passed
@shawnyama shawnyama deleted the new-doc-search branch February 23, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@dgauldie dgauldie Awaiting requested review from dgauldie

@dvince2 dvince2 Awaiting requested review from dvince2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] Explorer first pass updates
2 participants
@shawnyama @YohannParis