Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ts/2509 task update entity similarity api #2791

Merged
merged 8 commits into from
Feb 22, 2024

Conversation

Tom-Szendrey
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey commented Feb 22, 2024

Description

This updates the API to have the newly named similarity instead of distance
Also this updates minor formatting now that datasets are more consistent

Notes

I still need to make this only return the best result for each aka 1:1 mapping.
I will do that next PR.

Testing:

Add some concepts to a dataset and a model
hit the automap
check the logs to make sure it makes sense
check results to make sure it makes sense

image
[
    {
        "source": "ido:0000514",
        "target": "ido:0000514",
        "similarity": 1
    },
    {
        "source": "ido:0000514",
        "target": "vsmo:0000268",
        "similarity": 0.52754205
    },
    {
        "source": "ido:0000514",
        "target": "apollosv:00000235",
        "similarity": 0.4796577
    },
    {
        "source": "ido:0000511",
        "target": "ido:0000514",
        "similarity": 0.5856968
    },
    {
        "source": "ido:0000511",
        "target": "vsmo:0000268",
        "similarity": 0.45883524
    },
    {
        "source": "ido:0000511",
        "target": "apollosv:00000235",
        "similarity": 0.59226036
    },
    {
        "source": "ido:0000592",
        "target": "ido:0000514",
        "similarity": 0.5746397
    },
    {
        "source": "ido:0000592",
        "target": "vsmo:0000268",
        "similarity": 0.51967794
    },
    {
        "source": "ido:0000592",
        "target": "apollosv:00000235",
        "similarity": 0.45960027
    }
]

@Tom-Szendrey Tom-Szendrey merged commit 05115c1 into main Feb 22, 2024
8 checks passed
@Tom-Szendrey Tom-Szendrey deleted the TS/2509-task-update-entity-similarity-api branch February 22, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants