Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tera-asset.vue #2839

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Update tera-asset.vue #2839

merged 1 commit into from
Feb 27, 2024

Conversation

jamiewaese-uncharted
Copy link
Contributor

BEFORE
image

AFTER
image

shawnyama
shawnyama approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@shawnyama shawnyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider going into the PrimeVue themes and change the rules there next time. That way the problem will be solved for all components.

In this case you'd go to assets/css/theme/extensions/_tabview.scss

@jamiewaese-uncharted jamiewaese-uncharted merged commit a325411 into main Feb 27, 2024
5 checks passed
@jamiewaese-uncharted jamiewaese-uncharted deleted the jamie-fix-minor-bug-in-dataset-tab-selector branch February 27, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnyama shawnyama shawnyama approved these changes

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamiewaese-uncharted @shawnyama