fix[hmi-server]: incorrect parsing of some pdf urls #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't actually need to do a full encode here as most of the URLS given are coming from unpaywall and are good to go. What we mostly need to do is just replace whitespace with `%20`. This feels a little hacky to do but thats cowboy coding, baby! This works for random spot tests on PDFs as well as the previously problematic article with a DOI of 10.1101/2020.07.30.20164921
shawnyama
approved these changes
Feb 28, 2024
dvince2
deleted the
2850-bugpdf-viewer-is-broken-for-unpaywall-articles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't actually need to do a full encode here as most of the URLS given are coming from unpaywall and are good to go. What we mostly need to do is just replace whitespace with
%20. This feels a little hacky to do but thats cowboy coding, baby! This works for random spot tests on PDFs as well as the previously problematic article with a DOI of 10.1101/2020.07.30.20164921Resolves #2850