Add way to propagate task response handler errors to users. Fix scaling issue for response handlers. #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponse handlers.
kbirk
requested review from
YohannParis,
j2whiting,
dgauldie and
dvince2
as code owners
dvince2
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the response handlers (which should execute once, regardless of how many hmi-servers are running), would execute per hmi-server instance. This fixes that.
Response handlers should only run once, previously they would run once per hmi-server instance. This PR fixes that.
Catch response handler errors and dispatch those any relevant SSE Emitters.