Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update input ports on different output selection #2918

Merged
merged 21 commits into from
Mar 7, 2024
Merged

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Mar 5, 2024

Description

Before the input of a downstream node wouldn't update if a different output from the upstream node was chosen. Now it updates properly. Also if the downstream node is connected to anything or has any outputs those are all invalidated

Screen.Recording.2024-03-05.at.5.43.08.PM.mov

@shawnyama
Copy link
Contributor Author

shawnyama commented Mar 5, 2024

found a weird bug
EDIT: fixed it

Screen.Recording.2024-03-05.at.5.56.19.PM.mov

@shawnyama shawnyama requested a review from mwdchang March 6, 2024 15:58
@mwdchang mwdchang merged commit b88b22e into main Mar 7, 2024
8 checks passed
@mwdchang mwdchang deleted the dup-wf-node-fix branch March 7, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants