Reorg sciml calibrate #2942
Merged
Reorg sciml calibrate #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Szendrey
reviewed
Mar 7, 2024
packages/client/hmi-client/src/workflow/ops/calibrate-julia/calibrate-operation.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reorg sciml-calibrate operation, simplification of various things that were leftover from July hackathon , sync'ing between node/drilldown.
Note: I broke the tracking of the intermediate loss values, such that they are not saved properly when publishing an output. But this was already flaky to begin with so we will revisit once we have a first pass across other TA3 operators.