Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gollm fixes and improvements #2946

Merged
merged 11 commits into from
Mar 8, 2024
Merged

gollm fixes and improvements #2946

merged 11 commits into from
Mar 8, 2024

Conversation

blanchco
Copy link
Contributor

@blanchco blanchco commented Mar 7, 2024

Description

  • changes to the taskhanlder now that it is using a new event source library
  • bugfix to gollm controller
  • model config improvements

@blanchco blanchco self-assigned this Mar 7, 2024
@blanchco blanchco marked this pull request as ready for review March 7, 2024 18:48
YohannParis
YohannParis approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait until this ASYNC/async parameter is resolve.

@kbirk kbirk self-requested a review March 8, 2024 15:19
@kbirk
Copy link
Contributor

kbirk commented Mar 8, 2024

Let's wait until this ASYNC/async parameter is resolve.

I was wrong, my update didn't fix the enum casings. Lets merge this we can fix the casing stuff another day

@blanchco blanchco merged commit d726788 into main Mar 8, 2024
8 checks passed
@blanchco blanchco deleted the gollm-fixes-and-improvements branch March 8, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbirk kbirk kbirk approved these changes

@YohannParis YohannParis YohannParis approved these changes

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

@dvince2 dvince2 Awaiting requested review from dvince2 dvince2 is a code owner

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

Assignees

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blanchco @kbirk @YohannParis