Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone dataset-transform session on branching action #2953

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Mar 7, 2024

Summary

DataTransform has a state.notebookSessionId field that links to an ES document representing the notebook session, this means when we branch, subsequent modifications are written into the same doc from multiple sources creating weird inconsistencies.

This PR breaks this by adding a "clone" method, when branching happens DataTransform sessions are cloned are reassigned new ids.

Testing

  • Add a dataset to the workflow
  • Attach the dataset to a data-transform node
  • Branch the data-transform node
  • Do something, e.g. adding a column in one of the data-transform node
  • The two data-transforms should be separate entities and showing different data

@mwdchang mwdchang changed the title Dataset transform clone clone dataset-transform session on branching action Mar 7, 2024
@mwdchang mwdchang merged commit 79d3819 into main Mar 8, 2024
8 checks passed
@mwdchang mwdchang deleted the dataset-transform-clone branch March 8, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants