clone dataset-transform session on branching action #2953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DataTransform has a
state.notebookSessionId
field that links to an ES document representing the notebook session, this means when we branch, subsequent modifications are written into the same doc from multiple sources creating weird inconsistencies.This PR breaks this by adding a "clone" method, when branching happens DataTransform sessions are cloned are reassigned new ids.
Testing