Added welcome video to the home page banner #2954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiewaese-uncharted
requested review from
YohannParis and
mwdchang
as code owners
mwdchang
previously requested changes
Mar 8, 2024
There was a problem hiding this comment.
Please do not commit larger files (say larger than 4MB) into the git repo meant for source code. This makes things rather difficult to work with afterwards as it becomes a part of the permanent history and makes things really slow with working with git.
We should put the video somewhere else that is more dedicated to housing multimedia....like maybe on a publicly available S3 bucket or in the documentation-image or something.
|
I removed the video file and updated the thumbnail image. Should be good to go... ? |
YohannParis
approved these changes
Mar 19, 2024
YohannParis
dismissed
mwdchang’s stale review
Video is now hosted outside of GitHub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEFORE
AFTER
Note, this is the video we made for the CHI submission. We can easily change videos when we have a new one.