Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2947 feat improve error logging from the back end to the client #2955

Merged
merged 9 commits into from
Mar 8, 2024
Merged

2947 feat improve error logging from the back end to the client #2955

merged 9 commits into from
Mar 8, 2024

Conversation

dvince2
Copy link
Collaborator

@dvince2 dvince2 commented Mar 8, 2024

Description

  • api.ts no longer swallows error messages but rather will pop up a toast error message with the error code.
  • Front end toasts that were just logging a null have been removed because the toast will catch that now. Error messages that were front end specific or as a part of a catch have been kept in.
  • Some clean up on the dataservice side of hmi server
  • NOTE: This may surface some old bugs that had gone unseen because now 404 and 500 errors will pop to the front. We should deal with those problems as their own separately logged issues and not revert this change!!!

Resolves #2947

dvince2 added 5 commits March 7, 2024 13:17
@dvince2
feat [hmi-client]: improve error logging from the back end to the client
8f325b5 
Having `api.ts` drive all the error messages for server errors

Issue #2947
@dvince2
feat [hmi-client]: improve error logging from the back end to the client
7f09989 
Error handling the error handling

Issue #2947
@dvince2
feat [hmi-client]: improve error logging from the back end to the client
81d6b96 
Cleaning number of front end error messages

Issue #2947
@dvince2
feat [hmi-client]: improve error logging from the back end to the client
07e0438 
This exception handler was routing everything into a 400 error

Issue #2947
@dvince2
feat [hmi-client]: improve error logging from the back end to the client
60d5025 
Server side error cleaning.

Issue #2947
@dvince2 dvince2 requested review from Tom-Szendrey and blanchco March 8, 2024 16:00
@dvince2 dvince2 linked an issue Mar 8, 2024 that may be closed by this pull request
[FEAT]: Improve error logging from the back end to the client #2947
Closed
@YohannParis YohannParis requested a review from shawnyama March 8, 2024 16:07
YohannParis
YohannParis approved these changes Mar 8, 2024
View reviewed changes
packages/client/hmi-client/src/api/api.ts Outdated Show resolved Hide resolved
packages/client/hmi-client/src/api/api.ts Outdated Show resolved Hide resolved
packages/client/hmi-client/src/types/ServerError.ts Outdated Show resolved Hide resolved
packages/client/hmi-client/src/services/knowledge.ts Show resolved Hide resolved
dvince2 and others added 3 commits March 8, 2024 11:29
@dvince2 @YohannParis
Update packages/client/hmi-client/src/api/api.ts
33da112 
Co-authored-by: Yohann Paris <github@yohannparis.com>
@dvince2 @YohannParis
Update packages/client/hmi-client/src/api/api.ts
b68f139 
Co-authored-by: Yohann Paris <github@yohannparis.com>
@dvince2
feat [hmi-client]: improve error logging from the back end to the client
a4d97dd 
cleanup

Issue #2947
@dvince2 dvince2 merged commit fe5044d into main Mar 8, 2024
8 checks passed
@dvince2 dvince2 deleted the 2947-feat-improve-error-logging-from-the-back-end-to-the-client branch March 8, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis approved these changes

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: Improve error logging from the back end to the client
2 participants
@dvince2 @YohannParis