Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display nicer names for model framework #2970

Merged

Conversation

YohannParis
Copy link
Member

Description

  • Create a util to transform PascalCase into Sentence Case
  • Add more model framework compatibility, even if they are not supported yet.

Screenshot 2024-03-10 at 06 49 12

@YohannParis YohannParis requested a review from mwdchang as a code owner March 10, 2024 10:49
Base automatically changed from yohannparis/rename-equations-to-model-operator to main March 11, 2024 13:27
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused with the renaming situation going on here and why it is needed; but otherwise this looks fine.

@YohannParis
Copy link
Member Author

I am a bit confused with the renaming situation going on here and why it is needed; but otherwise this looks fine.

Because the Document to Model was renamed only in title to Equations to Model.
So I made sure the operator now matches that new title.

This PR should have been merge before the operator renaming, this PR was only about displaying nicer names for the dropdown. I should have done a better job when choosing my base.

@YohannParis YohannParis merged commit ab555cd into main Mar 11, 2024
5 checks passed
@YohannParis YohannParis deleted the yohannparis/display-nicer-names-for-framework-dropdown branch March 11, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants