Add askem admins to all projects #2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YohannParis
approved these changes
Mar 12, 2024
Not really certain what you mean, but I think you are asking, why check ReBAC if the user is a member of the admin group? The only place that there is knowledge that a given user (Yohann for instance) is in the admin group is within ReBAC, and ReBAC is designed to answer heirarchical permission calls. Additionally, having this part of ReBAC means that as long as the code check ReBAC for permissions there are no edge cases to memorize. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow ASKEM_Admins write permissions to all projects, both new and existing