fix: once a new output is generated update the selected output to it #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwdchang
reviewed
Mar 12, 2024
packages/client/hmi-client/src/components/drilldown/tera-output-dropdown.vue
Outdated
Show resolved
Hide resolved
mwdchang
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before when a new output was generated it appeared to be the chosen one once the output list was updated. In reality it was just a side effect of the list changing. I now select the new output after a new one is added (within
appendOutput())In the old version the new output looked like it was the selected one after a Run. However it was missing the connected label that should have been beside it.
Screen.Recording.2024-03-12.at.12.28.45.PM.mov