Open rename workflow text field in focus mode #3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiewaese-uncharted
requested review from
YohannParis and
mwdchang
as code owners
YohannParis
approved these changes
Mar 13, 2024
YohannParis
deleted the
jamie-open-rename-workflow-text-box-in-focus-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEFORE
After selecting 'Rename' you need to click in the input box before you begin typing. And it's not clear how to submit -- you can press enter or escape, but there's no signifier.
AFTER
Now we open the input box in focus mode. I also added a check mark that you can click, which runs the same 'updateWorkflowName' function as the enter and escape keys do.