semantic table change pt2 #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has massive overlap with my changes and not exactly compatible, we should sync up. |
Ya let's sync up Monday, just a general summary is that I'm switching to use model instead of model config as a prop since these need to be used in the model table. Hope it isn't too bad! |
YohannParis
approved these changes
Mar 19, 2024
packages/client/hmi-client/src/components/model/petrinet/tera-petrinet-tables.vue
Outdated
Show resolved
Hide resolved
packages/client/hmi-client/src/components/model/petrinet/tera-petrinet-tables.vue
Outdated
Show resolved
Hide resolved
packages/client/hmi-client/src/components/model/regnet/tera-regnet-tables.vue
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
*tables are now based off model
Screen.Recording.2024-03-18.at.4.21.48.PM.mov
Follows this schema whether a field is editable or not:
Model
Symbol
Name -> Editable
Description -> Editable
Concept -> Editable
Unit ->Editable
Value Type -> Editable
Value -> Editable
Source->Editable
Model Configuration
Symbol
Name
Description
Concept
Unit -> Editable
Value Type -> Editable
Value-> Editable
Source-> Editable
Resolves #(issue)