Fix issue with stalled requests if shutdown #3075
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this to be the cause of the stalled requests that @mwdchang experienced.
If the
hmi-server
was shutdown between writing the initialTaskStatus.QUEUED
state of the task to redis but before it actually sent the request to rabbitmq, then any subsequent request would simply wait for a non-existent task to finish.This is consistent with the logs as no request was sent, but it did timeout waiting for the response.
This switches the logic to write out the
TaskStatus.QUEUED
state after it is dispatched. If the server is shutdown after it dispatches to redis but before that state is set, then the subsequent requests will simply re-send it.Another small issue is that failed task id's were never re-written in the task SHA -> task id lookup. So after a task failed subsequent attempts, if successful, were not cached.