fix[hmi-client]: Show preview in drilldown #3077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a dataset drilldown, we should show the preview image
shawnyama
approved these changes
Mar 20, 2024
YohannParis
reviewed
Mar 20, 2024
Comment on lines
+55
to
+64
| if (datasetTemp && datasetTemp.esgfId) { | ||
| image.value = await getClimateDatasetPreview(datasetTemp.esgfId); | ||
| rawContent.value = null; | ||
| } else { | ||
| // We are assuming here there is only a single csv file. This may change in the future as the API allows for it. | ||
| rawContent.value = await downloadRawFile( | ||
| props.node.state.datasetId, | ||
| datasetTemp?.fileNames?.[0] ?? '' | ||
| ); | ||
| } |
There was a problem hiding this comment.
This would have been better done within the tera-dataset-description
There was a problem hiding this comment.
Should've noticed - I thought that's where the changes happened
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a dataset drilldown, we should show the preview image
Resolves #(issue)