Jamie adjust petrinet transition matrix rectangle widths #3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiewaese-uncharted
requested review from
YohannParis and
mwdchang
as code owners
…-transition-matrix-rectangle-widths
|
@jamiewaese-uncharted there are a couple matrix configurations that look a little odd. After: Before: |
|
Also note the notation we use is |
|
|
fyi
|
|
@mwdchang I fixed the last errors. Do you mind giving it a review please? |
mwdchang
approved these changes
Mar 27, 2024
mwdchang
deleted the
jamie-adjust-petrinet-transition-matrix-rectangle-widths
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something Pascale asked me to look into a while back. Finally figured it out. @mwdchang you may want to make sure I didn't break anything... but it looks good here.
BEFORE
AFTER
