Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logging of 403 and 401 errors #3138

Merged
merged 3 commits into from
Mar 24, 2024
Merged

Conversation

dgauldie
Copy link
Collaborator

Description

  • Include a summary of the changes and the related issue.
  • Include relevant motivation and context.

Resolves #(issue)

@dgauldie dgauldie requested a review from dvince2 as a code owner March 24, 2024 15:53
@dgauldie dgauldie linked an issue Mar 24, 2024 that may be closed by this pull request
2 tasks
@dgauldie
Copy link
Collaborator Author

dgauldie commented Mar 24, 2024

I tested that 401 and 403 errors get logged manually. If anyone feels up to writing unit tests for these new logging handlers, that would be great

@bigglesandginger
Copy link
Contributor

KeycloakJwtAuthenticationConverter.extractResourceRoles() checks to see if the user "isDirty" and if so updates the database (setting the user record and deleting all roles then adding all new roles)... will this fix the issue or make the issue revert to the old issue that PostGres will become hammered with database calls for every single request issued... (what the caching fixed)?

@dgauldie dgauldie merged commit 71c6e32 into main Mar 24, 2024
6 checks passed
@dgauldie dgauldie deleted the 3137-task-log-401-and-403-errors branch March 24, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK]: log 401 and 403 errors
2 participants